From ddc937b930b25afd9c4a64e65aab790842cb3c97 Mon Sep 17 00:00:00 2001 From: Krinkle Date: Wed, 7 Mar 2012 02:58:11 +0000 Subject: [PATCH] [mw.util.tooltipAccessKeyPrefix] alt-shift for Chrome on Windows * Fixes: -- (bug 29753) mw.util.tooltipAccessKeyPrefix should be alt-shift for Chrome on Windows --- RELEASE-NOTES-1.19 | 1 + resources/mediawiki/mediawiki.util.js | 14 +++++++++++--- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/RELEASE-NOTES-1.19 b/RELEASE-NOTES-1.19 index 52bd207f42..7e293deba9 100644 --- a/RELEASE-NOTES-1.19 +++ b/RELEASE-NOTES-1.19 @@ -258,6 +258,7 @@ production. * (bug 34600) Older skins using useHeadElement=false were broken in 1.18. * (bug 34604) [mw.config] wgActionPaths should be an object instead of a numeral array. +* (bug 29753) mw.util.tooltipAccessKeyPrefix should be alt-shift for Chrome on Windows === API changes in 1.19 === * Made action=edit less likely to return "unknownerror", by returning the actual error diff --git a/resources/mediawiki/mediawiki.util.js b/resources/mediawiki/mediawiki.util.js index 6edbe5d1d7..eade86ba37 100644 --- a/resources/mediawiki/mediawiki.util.js +++ b/resources/mediawiki/mediawiki.util.js @@ -29,9 +29,17 @@ // Chrome on any platform } else if ( profile.name === 'chrome' ) { - // Chrome on Mac or Chrome on other platform ? - util.tooltipAccessKeyPrefix = ( profile.platform === 'mac' - ? 'ctrl-option-' : 'alt-' ); + + util.tooltipAccessKeyPrefix = ( + // Chrome on Mac + profile.platform === 'mac' ? 'ctrl-option-' : + // Chrome on Windows + // (both alt- and alt-shift work, but alt-f triggers Chrome wrench menu + // which alt-shift-f does not) + profile.platform === 'win' ? 'alt-shift-' : + // Chrome on Ubuntu (and other?) + 'alt-' + ); // Non-Windows Safari with webkit_version > 526 } else if ( profile.platform !== 'win' -- 2.20.1